[Piglit] [RFC] shader_runner branch

Eric Anholt eric at anholt.net
Fri Apr 16 12:34:37 PDT 2010

On Thu, 15 Apr 2010 11:37:34 -0700, Ian Romanick <idr at freedesktop.org> wrote:
> Hash: SHA1
> I have a branch, called shader_runner, in my local GIT tree that adds a
> generic shader test runner.  There is a branch with the same name in the
> main piglit GIT tree, but that branch only contains fail.  My lack of
> GIT-fu shows.
>     git://anongit.freedesktop.org/~idr/piglit shader_runner
> It's conceptually similar to vpfp-generic, which is used for assembly
> shader tests.  The test files are "ini" style with "[section header]"
> section divisions.  The shader code can either be in the test file or
> stored in external files.  One of the planned future changes is to
> subsume the vpfp-generic functionality so that tests of mixing assembly
> and GLSL can be written.
> It currently only supports a subset of what we really want (i.e., it
> only supports setting vec4 uniforms), but it is very easy to add new
> features as needed.
> I'd like some review of this branch before I merge it.  In particular,
> the code uses some of the portability checks in cmake.  The commits
> listed below are the relevant changes.  I'd especially appreciate it if
> someone could try building this on OS X and Windows.

I've looked through the version in the main tree, as you probably
noticed from my push of some testcases to it.  It was really easy to
write and integrate the new testcases, so I'm pretty happy.

I don't really like the formatting of the test section:

uniform color vec4 0.0 1.0 0.0 0.0
draw rect -1 -1 2 2
probe rgb 1 1 0.0 1.0 0.0

Gah, that's a lot of numbers in a row.  Maybe something like:

uniform color vec4 (0.0, 1.0, 0.0, 0.0)
draw rect (-1, -1) (2, 2)
probe rgb (1, 1) (0.0, 1.0, 0.0)


Also, I'm tempted to have draw rect take x1, y2, x2, y2.  instead of x,
y, width, height.  I anticipate a lot of FS tests being in NDC, and the
(2, 2) looks goofy.

"uniform identifier type" felt strange to type instead of "uniform type
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20100416/ddf71807/attachment.pgp>

More information about the Piglit mailing list