[Piglit] [RFC] shader_runner branch

Ian Romanick idr at freedesktop.org
Fri Apr 16 13:04:34 PDT 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Eric Anholt wrote:
> I don't really like the formatting of the test section:
> 
> uniform color vec4 0.0 1.0 0.0 0.0
> draw rect -1 -1 2 2
> probe rgb 1 1 0.0 1.0 0.0
> 
> Gah, that's a lot of numbers in a row.  Maybe something like:
> 
> uniform color vec4 (0.0, 1.0, 0.0, 0.0)
> draw rect (-1, -1) (2, 2)
> probe rgb (1, 1) (0.0, 1.0, 0.0)
> 
> ?
> 
> Also, I'm tempted to have draw rect take x1, y2, x2, y2.  instead of x,
> y, width, height.  I anticipate a lot of FS tests being in NDC, and the
> (2, 2) looks goofy.
> 
> "uniform identifier type" felt strange to type instead of "uniform type
> identifier".

I made all of those choices to make parsing dead simple.  Right now the
parsing is just a for-loop of calls to strtof.  Adding punctuation will
make it necessary to write more code.  Changing the type / name order
for uniforms shouldn't be a problem, though.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvIwtAACgkQX1gOwKyEAw+dtwCdH8ngE4DLrkiRQzZpM6vAbDSu
hPsAnjUTYghEkfnRYxRJS4EmdsdNVf/Y
=W+lQ
-----END PGP SIGNATURE-----


More information about the Piglit mailing list