[Piglit] [PATCH v2] Add utilities for OpenGL ES 2.0

Ian Romanick idr at freedesktop.org
Mon Nov 8 15:37:27 PST 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/29/2010 12:40 AM, Shuang He wrote:
> This version has many changes according to krh's comment, like
>     sharing more codes
>     rename piglit-egl-framework to piglit-gles2-framework
>     rename egl_shader_runner to gles2_shader_runner

My problem with all of these tests is that they duplicate tons of
infrastructure.  This adds maintenance burden.  For example, I have a
patch to glslparsertest that adds the ability for tests to require
certain extension be present.  Now I have to make that patch in two
places.  As far as I can tell, the only difference between these tests
and the existing tests is the use of eglglut.  It seems that the right
answer it to just abstract out the parts that are different.

Also, I think patch 1/5 will break the build on Windows and Mac OS
platforms.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkzYibUACgkQX1gOwKyEAw+43wCfYO9vzxw1+0gdUXY5cgZsz4st
8J4An0dVkhORRaANa8BdD9LeO0w1rBZ2
=ejPX
-----END PGP SIGNATURE-----


More information about the Piglit mailing list