[Piglit] [PATCH 0/6] [with corrections] glslparsertest: Add diagnostic messages for when tests are skipped

Chad Versace chad at chad-versace.us
Tue Oct 12 17:53:42 PDT 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

idr, I've applied all the suggestions and corrections you made on my previous
submission of this patch. Below is a list of those changes.

After considering the suggestion that the test 'bitwise-01.frag' be retained,
I also added a test for bit-not in GLSL 1.20 (which fails, of course).

Patch 1/6:
- - Replaced the error message mentioning GLEW with the message you suggested.
- - Removed spurious, mysterious changes of stderr to stdout. (I think that was
  a vi search-and-replace mistake).

Patch 2/6:
- - Retain test bitwise-01.frag, but rename it to bit-not-01.frag in a separate
  commit.

Patch 3/6:
- - Introduce new test for bit-not in GLSL 1.20.

Patch 4/6:
- - In test involving `bool x = ~ true`, replace PASS with FAIL.

Patch 5/6:
- - Add a test for 'int << uint` and 'uint << int'.
- - Fix cut-and-paste fail.

Patch 6/6:
- - No change.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBAgAGBQJMtQDXAAoJEAIvNt057x8id90P/0VW4PIgdl5nGkPl6oxZJ4ce
Uma9UHPCYP253VJvUjBwvta6TKhOzV9PQ0bpTM9ZS/ekxg90hugRWGxYm2hsC2CN
q7K316R1L7MMcpyD1tIaEynxTxWAu9+JGOk+mdQjWvEJTv38vAUUHQMJVUwlvj84
ywpsCONHPkiPoB4iGLvYyT8NFgl/Eq2bCWLSxgAm/aR76MuRTZymo8ER2XtsobVm
4iagCNilYpVkM/oAjOfS4iAMjCvVCVLqFAKVcz/01Ni4dvaB3wdaLHHyh2Fw5PO4
s81mAGwavnydXhYlR3N/7Fwja11RuDhN5bI2jU5nbLPCd7Qc64S8IB4I0n6Z9D+B
gnfh0/8gYs0tVWA8qk3wiBKcQdTH6n03YCTO4mLFfAoIlDab+0DuOJuobWhP7EUy
PlCqULqNBUddbpwpSypgCw6qjRqBzZnWjyjQ9qb2AtHEDMSiE9o7GoIwGYcH72X3
XjEifaXVQe7VB0oYEUMkfoyDZKwGVyeWPkHwEMX26uc+ZLkkxPhcYiikwpLm4ElS
ZuS+A8ewj+fetEpSOnMM/kKjibJc2eggRplC5IVkcP9nqsuD8hK9IaDeQz/r8mI5
nCavBuBnoFCGbMdNzHJ12kR3uoamZeic8U++XQui36+ZdYZMNvIbnHo71lYkmCcV
AIC6i1zIM9zpYcszjJdq
=T54I
-----END PGP SIGNATURE-----


More information about the Piglit mailing list