[Piglit] [PATCH 1/6] glslparsertest: Add diagnostic messages for when tests are skipped

Chad Versace chad at chad-versace.us
Tue Oct 12 17:53:43 PDT 2010


From: Chad Versace <chad.versace at intel.com>

When glslparsertest skips a test, it now emits a message explaining why the
test is skipped.
---
 tests/glslparsertest/glslparsertest.c |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/tests/glslparsertest/glslparsertest.c b/tests/glslparsertest/glslparsertest.c
index 6b4f409..373b2d6 100644
--- a/tests/glslparsertest/glslparsertest.c
+++ b/tests/glslparsertest/glslparsertest.c
@@ -69,10 +69,14 @@ test(void)
 	}
 
 	if (!GLEW_VERSION_2_0) {
-		if (type == GL_FRAGMENT_SHADER && !GLEW_ARB_fragment_shader)
+		if (type == GL_FRAGMENT_SHADER && !GLEW_ARB_fragment_shader) {
+			fprintf(stderr, "Test requires OpenGL 2.0 or GL_ARB_fragment_shader\n");
 			piglit_report_result(PIGLIT_SKIP);
-		if (type == GL_VERTEX_SHADER && !GLEW_ARB_vertex_shader)
+		}
+		if (type == GL_VERTEX_SHADER && !GLEW_ARB_vertex_shader) {
+			fprintf(stderr, "Test requires OpenGL 2.0 or GL_ARB_vertex_shader\n");
 			piglit_report_result(PIGLIT_SKIP);
+		}
 	}
 
 	err = stat(filename, &st);
@@ -211,6 +215,10 @@ int main(int argc, char**argv)
 		? 0.0 : strtod(glsl_version_string, NULL);
 
 	if (glsl_version < minimum_version) {
+		fprintf(stderr,
+			"GLSL version is %f, but minimum version %f is required\n",
+			glsl_version,
+			minimum_version);
 		piglit_report_result(PIGLIT_SKIP);
 	} else {
 		test();
-- 
1.7.1



More information about the Piglit mailing list