[Piglit] Build broken since cccc419e2 (python generated tests)

Paul Berry stereotype441 at gmail.com
Mon Aug 8 11:56:38 PDT 2011


On 6 August 2011 18:24, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On 08/06/2011 05:29 PM, Paul Berry wrote:
>> On 5 August 2011 19:13, Kenneth Graunke <kenneth at whitecape.org> wrote:
>>> Hi Paul,
>>>
>>> cmake dies for me when trying to generate your built-in tests.
>>>
>>> On Archlinux, /usr/bin/python and /usr/bin/python3 are Python 3.2, while
>>> Python 2 is /usr/bin/python2.  cmake tries to run your scripts using
>>> plain 'python', which dies quickly.
>>>
>>> Mesa ends up checking for the existance of 'python2' first and prefers
>>> that to 'python'.  This works pretty well.  Not sure how to do that in
>>> CMake.
>>
>> Ok, I have a patch which I believe fixes the problem on ArchLinux.
>> I'll send it to the list shortly.  Would you mind letting me know if
>> it works?  I have done some testing under ArchLinux, but my ArchLinux
>> install is in a VM, and is only half working at this point (I started
>> it this morning), so I can't test it as thoroughly as I would like.
>
> The patch looks great and solves the problem.  Feel free to mark it with
> my Reviewed-by.  Sorry for the trouble; I didn't mean for you to have to
> install a whole OS just for this.  I figured changing a few files in
> /usr/bin temporarily would do the trick...!

Thanks for testing.  And no worries about the extra time I spent on
ArchLinux.  I've been meaning to get familiar with more distros
(precisely so that I can avoid creating this sort of problem in the
future) and this was a good excuse :)


More information about the Piglit mailing list