[Piglit] Build broken since cccc419e2 (python generated tests)

Vinson Lee vlee at vmware.com
Sat Aug 6 21:39:28 PDT 2011

On Aug 6, 2011, at 6:24 PM, Kenneth Graunke wrote:

> On 08/06/2011 05:29 PM, Paul Berry wrote:
>> Do you think there would be any objection if I standardize on using
>> 4-space indentation (as recommended in
>> http://www.python.org/dev/peps/pep-0008/)?  I realize that most of
>> Piglit's Python code uses tabs for indentation, but 4-space
>> indentation has been recommended best practice in Python since 2001,
>> and since we're probably going to be reviewing most of Piglit's Python
>> code in preparation for the move to Python 3 anyhow, this seems like a
>> good time to start following the standard.
>> Paul
> That's my preference as well, but I can't speak for others.

I wouldn't object and prefer this for the Python code too. However, if the steps to 4-space indentation is taken, I suggest we be more pedantic and make all Piglit Python code adhere to PEP 8.

The pep8 package (http://pypi.python.org/pypi/pep8) is a useful tool for checking code against PEP 8.

More information about the Piglit mailing list