[Piglit] [PATCH 05/12] glx_arb_create_context: Verify that the attributes list pointer can be NULL

[Ian Romanick]

From: Ian Romanick <ian.d.romanick at intel.com>

Both AMD's and NVIDIA's closed-source drivers pass this test.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 tests/all.tests                                    |    1 +
 .../spec/glx_arb_create_context/CMakeLists.gl.txt  |    1 +
 .../glx_arb_create_context/valid-attribute-null.c  |   63 ++++++++++++++++++++
 3 files changed, 65 insertions(+), 0 deletions(-)
 create mode 100644 tests/spec/glx_arb_create_context/valid-attribute-null.c

diff --git a/tests/all.tests b/tests/all.tests
index 193ac59..2f9b266 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -628,6 +628,7 @@ glx['GLX_ARB_create_context'] = create_context
 create_context['default major version'] = PlainExecTest(['glx-create-context-default-major-version'])
 create_context['default minor version'] = PlainExecTest(['glx-create-context-default-minor-version'])
 create_context['empty attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-empty'])
+create_context['NULL attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-null'])
 
 texturing = Group()
 add_concurrent_test(texturing, '1-1-linear-texture')
diff --git a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
index 531db1d..c5e7a2f 100644
--- a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
+++ b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
@@ -18,6 +18,7 @@ IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
 	add_executable (glx-create-context-default-major-version default-major-version.c common.c)
 	add_executable (glx-create-context-default-minor-version default-minor-version.c common.c)
 	add_executable (glx-create-context-valid-attribute-empty valid-attribute-empty.c common.c)
+	add_executable (glx-create-context-valid-attribute-null valid-attribute-null.c common.c)
 ENDIF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
 
 # vim: ft=cmake:
diff --git a/tests/spec/glx_arb_create_context/valid-attribute-null.c b/tests/spec/glx_arb_create_context/valid-attribute-null.c
new file mode 100644
index 0000000..cacc47e
--- /dev/null
+++ b/tests/spec/glx_arb_create_context/valid-attribute-null.c
@@ -0,0 +1,63 @@
+/* Copyright © 2011 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+#include "piglit-util.h"
+#include "piglit-glx-util.h"
+#include "common.h"
+
+int main(int argc, char **argv)
+{
+	bool pass = true;
+	GLXContext ctx;
+
+	GLX_ARB_create_context_setup();
+
+	/* The GLX_ARB_create_context spec says:
+	 *
+	 *     "<attrib_list> may be NULL or empty (first attribute is None),
+	 *     in which case all attributes assume their default values as
+	 *     described below.
+	 *
+	 *     ...
+	 *
+	 *     The default values for GLX_CONTEXT_MAJOR_VERSION_ARB and
+         *     GLX_CONTEXT_MINOR_VERSION_ARB are 1 and 0 respectively. In this
+         *     case, implementations will typically return the most recent
+         *     version of OpenGL they support which is backwards compatible
+         *     with OpenGL 1.0 (e.g. 3.0, 3.1 + GL_ARB_compatibility, or 3.2
+         *     compatibility profile)."
+	 *
+	 * The Linux OpenGL ABI requires at least OpenGL 1.2, so this must
+	 * create a context.
+	 */
+	ctx = glXCreateContextAttribsARB(dpy, fbconfig, NULL, True, NULL);
+	if (ctx == NULL) {
+		fprintf(stderr,	"Unable to create OpenGL context!\n");
+		pass = false;
+	} else {
+		glXDestroyContext(dpy, ctx);
+	}
+
+	GLX_ARB_create_context_teardown();
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+	return 0;
+}
-- 
1.7.6.4