[Piglit] [PATCH 04/12] glx_arb_create_context: Verify that the attributes list can be empty

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/14/2011 10:47 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Both AMD's and NVIDIA's closed-source drivers pass this test.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  tests/all.tests                                    |    1 +
>  .../spec/glx_arb_create_context/CMakeLists.gl.txt  |    1 +
>  .../glx_arb_create_context/valid-attribute-empty.c |   66 ++++++++++++++++++++
>  3 files changed, 68 insertions(+), 0 deletions(-)
>  create mode 100644 tests/spec/glx_arb_create_context/valid-attribute-empty.c
> 

> +	/* The GLX_ARB_create_context spec says:
> +	 *
> +	 *     "<attrib_list> may be NULL or empty (first attribute is None),
> +	 *     in which case all attributes assume their default values as
> +	 *     described below.
> +	 *
> +	 *     ...
> +	 *
> +	 *     The default values for GLX_CONTEXT_MAJOR_VERSION_ARB and
> +         *     GLX_CONTEXT_MINOR_VERSION_ARB are 1 and 0 respectively. In this
> +         *     case, implementations will typically return the most recent
> +         *     version of OpenGL they support which is backwards compatible
> +         *     with OpenGL 1.0 (e.g. 3.0, 3.1 + GL_ARB_compatibility, or 3.2
> +         *     compatibility profile)."

Indentation again. The same misformatting occurs in patch 5/12 too.

Other than the indentation, patches 4 and 5 are
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJO8OY2AAoJEAIvNt057x8iBmUP+gPo+zY4OefJhMI4+/nWzHLR
ahOgAkvTTV2EOmY7qE/RnHlaQPhyiFtc+qAS4cLpsVVGyS82jpJLMdLnb7s2+eh8
K5IGmL2jmZTAPtDDfts6Mcin/DWaBKlRoXO9dcztUS4I3U0ItJ0GJLl+h4g0fONp
EuOAM3xE3+PPx1bJP7pSbhReOwslU2jekWpjPQ9hvg/xNAJVgEtM4FGSe6K8k++H
8Nl1HuLW7o+J8zXDcLmUvU07Q7y3Woh9gbhlbrc+MzMwSXCMEMqqq30QDRJ0d7Su
e/wWR1m9ttZIDQubZnldzKggJrsT2a0NZh86GxzMPEknIn5ZxJSPgdiL8cZw9/J1
dVdn/JEDQduZEo1ATjqfoQnY0JqDAzX4fri6KFys7MVg7Egm6D5kI7G4xcBAkJoA
uq8TfLxWTIRLCBxb7h2FOZR+BsjhQXki3yYu4fwTUpiGU81STdL4ty2VoxTqMoYi
5SOAkPnu36wk5qj/JWcETL3aBP7eqFbihchPUgt5JiRvFGufY21YxshPcD03rfB0
mDRG1WroiZOeYsQp4fGWIuknCsTa4g63J9W5uebz4HLsff3ZDGHIo0TN+brVtUj+
zOj0lIV6dq/y4y4ks9eT3ZkNN/PDgTmOC3WPlJJRR/KW97Uowv35JyZcYJ0o8Z7U
u924FtpD1eC9sgFqcCxl
=rmWg
-----END PGP SIGNATURE-----