[Piglit] [PATCH] [v3] Add test case on error check on glGetTexImage with type

Brian Paul brianp at vmware.com
Tue Dec 20 14:27:38 PST 2011


On 12/20/2011 01:52 PM, Ian Romanick wrote:
> On 12/18/2011 06:46 PM, Zhao, Jian J wrote:
>>> -----Original Message-----
>>> From: Ian Romanick [mailto:idr at freedesktop.org]
>>> Sent: Saturday, December 17, 2011 8:24 AM
>>> To: Zhao, Jian J
>>> Cc: piglit at lists.freedesktop.org
>>> Subject: Re: [PATCH] [v3] Add test case on error check on
>>> glGetTexImage
>>> with type
>>>
>>> On 12/14/2011 06:10 PM, jian.j.zhao at intel.com wrote:
>>>> From: Jian Zhao<jian.j.zhao at intel.com>
>>>> + if (!pxBuffer)
>>>> + return PIGLIT_FAIL;
>>>> +
>>>> + for(i=0; i< ARRAY_SIZE(formatTypes); i++)
>>>> + {
>>>
>>> Whitespace errors.
>>
>> Can you please tell me what is the expected whitespace?
>
> The same as it has always been:
>
> - One space on either side of a binary operator or =.
>
> - Curly braces and control-flow (for, while, if, else, switch, etc.)
> go on the same line.
>
> - No white space after '(' or before ')'.
>
> The usual answer in any large code base is that if your code looks
> different from the majority of the rest of the code, your code is
> formatted wrong. :)

It would probably be useful to figure out the right 'indent' 
incantation to produce the desired formatting.  Anyone?

-Brian


More information about the Piglit mailing list