[Piglit] [PATCH] [v3] Add test case on error check on glGetTexImage with type

[Zhao, Jian J]

> -----Original Message-----
> From: Ian Romanick [mailto:idr at freedesktop.org]
> Sent: Wednesday, December 21, 2011 4:52 AM
> To: Zhao, Jian J
> Cc: piglit at lists.freedesktop.org
> Subject: Re: [PATCH] [v3] Add test case on error check on glGetTexImage
> with type
> 
> On 12/18/2011 06:46 PM, Zhao, Jian J wrote:
> >> -----Original Message-----
> >> From: Ian Romanick [mailto:idr at freedesktop.org]
> >> Sent: Saturday, December 17, 2011 8:24 AM
> >> To: Zhao, Jian J
> >> Cc: piglit at lists.freedesktop.org
> >> Subject: Re: [PATCH] [v3] Add test case on error check on glGetTexImage
> >> with type
> >>
> >> On 12/14/2011 06:10 PM, jian.j.zhao at intel.com wrote:
> >>> From: Jian Zhao<jian.j.zhao at intel.com>
> >>> +	if (!pxBuffer)
> >>> +		return PIGLIT_FAIL;
> >>> +
> >>> +	for(i=0; i<   ARRAY_SIZE(formatTypes); i++)
> >>> +	{
> >>
> >> Whitespace errors.
> >
> > Can you please tell me what is the expected whitespace?
> 
> The same as it has always been:
> 
>   - One space on either side of a binary operator or =.
> 
>   - Curly braces and control-flow (for, while, if, else, switch, etc.)
> go on the same line.
> 
>   - No white space after '(' or before ')'.
> 
> The usual answer in any large code base is that if your code looks
> different from the majority of the rest of the code, your code is
> formatted wrong. :)

OK. Thanks. I will change it to this style, though there is already v4 now.  :)  

Best regards
ZhaoJian

> 
> >>> +		glGetTexImage(GL_TEXTURE_2D, 0, formatTypes[i],
> >>> +			    GL_UNSIGNED_INT_10F_11F_11F_REV_EXT,
> >>
> >> Should also test the non-REV format.
> >
> > Do you mean also test other types like GL_UNSIGNED_BYTE_3_3_2,
> GL_UNSIGNED_BYTE_2_3_3_REV...? If so I will add them in the next patch
> update.
> >
> >>
> >>> +			    pxBuffer);
> >>> +		rcvError = glGetError();
> >>> +		if ( formatTypes[i] == GL_RGB )
> >>
> >> Whitespace errors.