[Piglit] [PATCH] Added a simple logging class. Updated Test::doRun to use the new log.

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/20/2011 09:30 AM, Ian Romanick wrote:
> On 01/19/2011 05:25 PM, U. Artie Eoff wrote:
>> Added log.py which includes a simple Logger class that wraps some
>> basic functions from the Python logging module. The log wrapper
>> simplifies setup and will accommodate thread synchronization in the
>> future.  Test::doRun now uses the new log facility.
>> NOTE: this changes the format of the 'test progress' previously
>> printed via stdout.
> 
>> Added patterns.py which includes a Singleton class design pattern
>> to support the Logger class.  Future design patterns can be added
>> to this file.
> 
>> Tested with Python 2.7 on Linux.  All should be compatible with
>> Windows and Mac and most earlier widely-used versions of Python.
> 
> I like the change.  I want some comment from non-Intel people before I
> push this change.  Part of the reason for the change in output format is
> that Artie's next change set is going to make CPU-only tests (e.g., all
> of the parser tests) and GPU tests run concurrently.  Without this
> change to the logging, you'd see things like:
> 
> Test: some_test
> Test: some_other_test
>     result: skip
>     result: fail
> 
> That seems bad.  Which test failed and which test was skipped?
> 
> I'd like to hear
> 
> a) People don't hate the change.
> 
> b) The change works on Mac and Windows.

Three weeks of crickets seems like enough.  I just pushed this patch.
Hopefully Artie's patches to run tests in parallel will make it to the
list soon.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk1QRjQACgkQX1gOwKyEAw/XpgCggxl73W+XnWj3tjoFumNsg5r9
8pMAnRYQzGKvmxdQWhtfGlokBrjr4OHg
=yC0S
-----END PGP SIGNATURE-----