[Piglit] Question on commit 4259ce: all.tests: Remove glslparsertest CorrectPreprocess11.frag test

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vinson, I have a question on commit 4259ce. (For reference, the commit
is reproduced below.) Could you please explain what is wrong with the
test CorrectPreprocess11.frag?

Also, if the test is indeed incorrect, I believe the proper way to
remove it would have been to delete the test file itself.

Chad Versace
chad.versace at intel.com
chad at chad-versace.us

- -- begin commit --

commit 4259ce0982d264372a7994ca77bc6452eb7e5879
Author: Vinson Lee <vlee at vmware.com>
Date:   Sat Jan 8 01:57:33 2011 -0800

    all.tests: Remove glslparsertest CorrectPreprocess11.frag test.

    Remove CorrectPreprocess11.frag from the test list because it is wrong.

diff --git a/tests/all.tests b/tests/all.tests
index 7761c32..f52e710 100644
- --- a/tests/all.tests
+++ b/tests/all.tests
@@ -1079,6 +1079,7 @@ for filename in
os.listdir('tests/glslparsertest/shaders'):
 	ext = filename.rsplit('.')[-1]
 	if ext in ['vert', 'geo', 'frag']:
 		add_glsl_parser_test(glslparsertest,
path.join('tests/glslparsertest/shaders', filename), filename)
+del glslparsertest['CorrectPreprocess11.frag']
 for filename in os.listdir('tests/glslparsertest/glsl2'):
 	ext = filename.rsplit('.')[-1]
 	if ext in ['vert', 'geo', 'frag']:

- -- 
Chad Versace
chad.versace at intel.com
chad at chad-versace.us
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJNKkFlAAoJEAIvNt057x8icZwP/jvJLIOvLEPwDDLOORWYMtKX
AGwxBvQ9T3Xc9OG1gC+2fCoxeNTeeE5ZqKUZonOSvaK9JL4GfXMl9ug1Z7MS7igo
fpjJMFGdhkjDem8OZO7hhn8jkxRF+W7ag/m9fP3YhXkqE/UeBVFqw8XeqPlgrGwc
0Yt0Oo4JN8boWLwGSFMFMvk/U7Fdwf58bTcV9ucmr8zqSofZ1+yzEeWKFsUiF/oc
P7hL3n6+PRqScTT2nGRmbwwVFyADXafmXo5GLkRvz2Rhr4g49wcguKFQBwzQ+D9z
AInJRqUSLwjisA3/92j8JAN6sIzZsZyyFwOY6eLnwGdv9xYTQj4dfZedOVPULL3X
70sKwWCDP0oU12Lpl+fpNSDHjfNlw8pPJcuWiMJDhp8CuMJSH+XTu/vP4UwnKp99
5h8eIoUIJUdtQYMOzpg584KaO9gdmtf2pZAp1hs04Llw6Huupk1xYMLqgKtPVuuG
DejTxf15gSk8hsEOE547vbZBZdtWmkDNwY5OpPJJfQ4qtGO3JHxdcyFpF+8m7fdY
SrABLFy40iIbyltWELj8WNX2fA3MOJiEqCIk7KiUjJ+Jwiy8Y205crLzUYmtSJGZ
Zj2TkTEOUWQcdpTON4/3FzJ9gAjdr7NCTiVMvoMKcRNn5dsfYUlsO4f+OzdBbmZG
LZoFIEcXcXo1Kv9EUo7Y
=KuLM
-----END PGP SIGNATURE-----