[Piglit] Question on commit 4259ce: all.tests: Remove glslparsertest CorrectPreprocess11.frag test

Ian Romanick idr at freedesktop.org
Mon Jan 10 08:37:24 PST 2011

Hash: SHA1

On 01/09/2011 03:14 PM, Chad Versace wrote:
> Vinson, I have a question on commit 4259ce. (For reference, the commit
> is reproduced below.) Could you please explain what is wrong with the
> test CorrectPreprocess11.frag?
> Also, if the test is indeed incorrect, I believe the proper way to
> remove it would have been to delete the test file itself.

All of the tests in the shaders/ directory came from the old 3dlabs GLSL
tests.  We've had an implicit goal of not modifying those tests.  This
is why all of our new tests were added in the glsl2/ directory.  It is
worth noting that many of these tests were imported into the OpenGL ES
2.0 test suite.  However, CorrectPreprocess11.frag is not one of them.

The problem with CorrectPreprocess11.frag is that it uses incorrect
#ifdef syntax.  Line 43 (shown below) is wrong.

#ifdef pine please raise a warning

The test also contains an erroneous macro redefinition at line 56.

This test was also not included in the test list prior to 71bb53336
(glslparsertest: Replace manual listing of tests with auto-discovery).
Since this test doesn't include a [config] section, it shouldn't be
included now either.  In my test results it shows up a "skip".
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/


More information about the Piglit mailing list