[Piglit] Spec test organization

Ian Romanick idr at freedesktop.org
Mon Jan 10 17:19:18 PST 2011

Hash: SHA1

On 01/10/2011 05:17 PM, Brian Paul wrote:
> On 01/10/2011 01:23 PM, Ian Romanick wrote:
>> Hash: SHA1
>> I'm in the process of adding tests for some GLSL extensions.  At least
>> some of these extensions have slightly different interactions with
>> different GLSL versions.  For that reason, I want to have separate tests
>> for 1.10, 1.20, and 1.30.  Does anyone have an opinion has to how these
>> tests should be organized?
>> Right now we have tests/spec/glsl-1.30/{compiler,preprocessor}.  As my
>> tests are currently written, they are in tests/spec/[EXTENSION
>> NAME]/{compiler,preprocessor}/foo-{110,120,130}-##.{vert,frag}.  Does
>> that seem good, or would it be better to have separate 1.10, etc.
>> directories under tests/spec/[EXTENSION NAME]/?  Should that be above
>> {compiler,preprocessor} or below?
>> In other words:
>> a) tests/spec/ext_foo_bar/compiler/foo-110-01.vert
>> b) tests/spec/ext_foo_bar/1.10/compiler/foo-01.vert
>> c) tests/spec/ext_foo_bar/compiler/1.10/foo-01.vert
>> I'm currently leaning towards "a."  My second choice is "b" due to the
>> way it will cause test results to be formatted in piglit's HTML output.
> I guess I don't have a strong opinion.  But why separate dirs for
> compiler vs. preprocessor tests?  Eliminating that would make the tree a
> little shallower...

That just mirrors what Chad did with the 1.30 tests.  He had separate
compiler, preprocessor, and linker directories.  It makes a bit more
sense there because there are a lot more tests specific to the
preprocessor.  I copied that for consistency sake.
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/


More information about the Piglit mailing list