[Piglit] Spec test organization

Brian Paul brianp at vmware.com
Mon Jan 10 17:17:06 PST 2011

On 01/10/2011 01:23 PM, Ian Romanick wrote:
> Hash: SHA1
> I'm in the process of adding tests for some GLSL extensions.  At least
> some of these extensions have slightly different interactions with
> different GLSL versions.  For that reason, I want to have separate tests
> for 1.10, 1.20, and 1.30.  Does anyone have an opinion has to how these
> tests should be organized?
> Right now we have tests/spec/glsl-1.30/{compiler,preprocessor}.  As my
> tests are currently written, they are in tests/spec/[EXTENSION
> NAME]/{compiler,preprocessor}/foo-{110,120,130}-##.{vert,frag}.  Does
> that seem good, or would it be better to have separate 1.10, etc.
> directories under tests/spec/[EXTENSION NAME]/?  Should that be above
> {compiler,preprocessor} or below?
> In other words:
> a) tests/spec/ext_foo_bar/compiler/foo-110-01.vert
> b) tests/spec/ext_foo_bar/1.10/compiler/foo-01.vert
> c) tests/spec/ext_foo_bar/compiler/1.10/foo-01.vert
> I'm currently leaning towards "a."  My second choice is "b" due to the
> way it will cause test results to be formatted in piglit's HTML output.

I guess I don't have a strong opinion.  But why separate dirs for 
compiler vs. preprocessor tests?  Eliminating that would make the tree 
a little shallower...


More information about the Piglit mailing list