[Piglit] [PATCH] Added simple thread-safe logging support
idr at freedesktop.org
Wed Jan 19 10:30:21 PST 2011
-----BEGIN PGP SIGNED MESSAGE-----
On 01/18/2011 03:45 PM, Chad Versace wrote:
> Patch disregarded. Still, there was one style point I want to comment on.
> Please begin function names with lower case. Currently, all Piglit
> functions use thisCamelCaseConvention, NotThisOne, as `grep def
> framework/*.py` will reveal.
There also seems to be a lot of whitespace chaff. For example, there
are a bunch of blank lines at the end of log.py. It's probably worth
tightening that up a bit.
What's different in the new approach? That code looked pretty good. I
had expected more than 180-ish lines of changes, so I was pleasantly
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the Piglit