[Piglit] [PATCH] Added simple thread-safe logging support
Eoff, Ullysses A
ullysses.a.eoff at intel.com
Wed Jan 19 10:55:11 PST 2011
> -----Original Message-----
> From: Ian Romanick [mailto:idr at freedesktop.org]
> Sent: Wednesday, January 19, 2011 10:30 AM
> To: chad at chad-versace.us
> Cc: Eoff, Ullysses A; piglit at lists.freedesktop.org
> Subject: Re: [Piglit] [PATCH] Added simple thread-safe logging support
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> On 01/18/2011 03:45 PM, Chad Versace wrote:
> > Patch disregarded. Still, there was one style point I want to comment
> > Please begin function names with lower case. Currently, all Piglit
> > functions use thisCamelCaseConvention, NotThisOne, as `grep def
> > framework/*.py` will reveal.
> There also seems to be a lot of whitespace chaff. For example, there
> are a bunch of blank lines at the end of log.py. It's probably worth
> tightening that up a bit.
> What's different in the new approach? That code looked pretty good. I
> had expected more than 180-ish lines of changes, so I was pleasantly
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
> -----END PGP SIGNATURE-----
The new approach will hopefully remove the use of the Python logging module.
I just think its API is too complex for what we need at this point and
probably adds more overhead than needed. Perhaps something will change my
mind later, however.
More information about the Piglit