[Piglit] [PATCH] Add comprehensive tests of builtin functions with uniform input.

[Vinson Lee]

> -----Original Message-----
> From: Jose Fonseca [mailto:jfonseca at vmware.com]
> 
> ----- Original Message -----
> > On 22 July 2011 15:19, Vinson Lee <vlee at vmware.com> wrote:
> > > The hard requirement of python-2.7 and numpy will make piglit not
> > > buildable on many default environments, including Ubuntu 10.10 and
> > > Snow Leopard. I prefer a soft requirement where piglit warns and
> > > doesn't generate these new tests if the requirements aren't met.
> >
> > Vinson and I took a look at this in more detail and here's what we
> > found:
> >
> > - Ubuntu 10.10 and Snow Leopard both have numpy available (in fact,
> > on
> > Snow Leopard it's installed by default).
> > - We don't know how easy it is to install numpy on Windows, however
> > there is a Windows binary available from numpy.scipy.org, so
> > presumably it is not difficult.
> > - Ubuntu 10.10 and Snow Leopard ship with Python 2.6.
> > - I don't know what versions of Python are available on Windows,
> > however other parts of Piglit have depended on Python 2.6 since at
> > least as far back as November 2010 (in spite of the README's
> > assertion
> > that Python 2.4 was sufficient).  So presumably Python 2.6 is
> > obtainable on Windows.
> > - Removing this patch's dependency on Python 2.7 would be fairly
> > trivial--just switch from using argparse to optparse.  It would be
> > unfortunate, since optparse is deprecated as of Python 2.7, but I'm
> > sure far worse crimes than this have been committed.
> > - Removing this patch's dependency on numpy would be a lot more work
> > (since the test generation code that currently performs vector
> > operations would have to be rewritten in native Python, decreasing
> > confidence that the tests are correct).
> > - A disadvantage of the "soft requirement" approach would be that for
> > users of OSes in which numpy is easily available but not installed by
> > default (e.g. Fedora, Ubuntu, and I suspect all other Linux distros),
> > these users would not be alerted to the fact that they were missing
> > out on useful tests.  This would constitute a gap in test coverage
> > for
> > those who didn't notice the new soft requirement on numpy.
> >
> > (Vinson, I hope I've represented your contribution to the discussion
> > adequately; if I haven't please feel free to reply)
> >
> > Based on this, my proposal would be:
> >
> > - Remove the requirement on Python 2.7 by switching to optparse
> > instead of argparse
> > - Retain the hard requirement on numpy.
> 
> OK. Thanks for the summary. I have no objections with your proposal.
> 
> Jose

I have no objections either. This is a good balance with having more tests and still be able to run them on many platforms and distros.

Should we do a piglit release before the new requirements go in? There's only been one release of piglit-v1 two years ago.