[Piglit] [PATCH] Add test case for glDrawElementsInstancedBaseVertex

Pierre-Eric Pelloux-Prayer pelloux at gmail.com
Thu Jun 2 09:18:04 PDT 2011

On Wed, Jun 1, 2011 at 8:41 PM, Eric Anholt <eric at anholt.net> wrote:
> On Wed, 1 Jun 2011 10:28:52 +0200, Pierre-Eric Pelloux-Prayer <pelloux at gmail.com> wrote:
>> [...]
> We've started a trend of putting tests specific to an extension under
> tests/spec/extensionname.  For better or worse we haven't gone back and
> done that retroactively.  For this test, which is about an interaction
> between two extensions, I'd just pick one to put it under.  Probably
> GL_ARB_draw_instanced.

I put it under the a new spec folder :
tests/spec/arb_draw_elements_base_vertex as the tested method belongs
to GL_ARB_draw_elements_base_vertex.
Is it ok ?
I'm also supplying an optional second patch, which moves the 2
existing tests of this spec to the newly created folder.

> There's some strange indenting (spaces instead of tabs) that should get
> fixed up.  It's probably also copyright you even if you derived from an
> Intel test -- I'd encourage you to add a Copyright line too.

Should be fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adds-test-case-for-glDrawElementsInstancedBaseVertex.patch
Type: text/x-patch
Size: 8309 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20110602/c7aeadf6/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Moved-existing-GL_ARB_draw_elements_base_vertex-test.patch
Type: text/x-patch
Size: 18209 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20110602/c7aeadf6/attachment-0003.bin>

More information about the Piglit mailing list