[Piglit] [PATCH] Add test case for glDrawElementsInstancedBaseVertex

Eric Anholt eric at anholt.net
Fri Jun 3 14:03:52 PDT 2011

On Thu, 2 Jun 2011 18:18:04 +0200, Pierre-Eric Pelloux-Prayer <pelloux at gmail.com> wrote:
> On Wed, Jun 1, 2011 at 8:41 PM, Eric Anholt <eric at anholt.net> wrote:
> > On Wed, 1 Jun 2011 10:28:52 +0200, Pierre-Eric Pelloux-Prayer <pelloux at gmail.com> wrote:
> >> [...]
> >
> > We've started a trend of putting tests specific to an extension under
> > tests/spec/extensionname.  For better or worse we haven't gone back and
> > done that retroactively.  For this test, which is about an interaction
> > between two extensions, I'd just pick one to put it under.  Probably
> > GL_ARB_draw_instanced.
> I put it under the a new spec folder :
> tests/spec/arb_draw_elements_base_vertex as the tested method belongs
> to GL_ARB_draw_elements_base_vertex.
> Is it ok ?
> I'm also supplying an optional second patch, which moves the 2
> existing tests of this spec to the newly created folder.

Thanks, I applied the first patch.

I'm not sure how others feel about rearranging some of the existing
tests.  If we decide we'd like to, I'd rather see a big push to move
things all at once than to go incrementally, to make things easier on
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20110603/c327a0c4/attachment.pgp>

More information about the Piglit mailing list