[Piglit] [PATCH] piglit_util: return 0 when piglit_compile_shader_text() fails

Eric Anholt eric at anholt.net
Wed May 18 12:37:40 PDT 2011


On Wed, 18 May 2011 11:45:05 -0600, Brian Paul <brianp at vmware.com> wrote:
> or when piglit_link_simple_program() fails.  Callers can then check
> the return value to see if compiling/linking worked.

I like it.

I wonder, though, how many callers of the simple compile functions want
anything but piglit_report_result(PIGLIT_FAIL) on compile/link failure?
Having tests try to continue on rendering on failure sucks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20110518/71ebe46e/attachment.pgp>


More information about the Piglit mailing list