[Piglit] [PATCH] piglit_util: return 0 when piglit_compile_shader_text() fails
brianp at vmware.com
Wed May 18 13:04:02 PDT 2011
On 05/18/2011 01:37 PM, Eric Anholt wrote:
> On Wed, 18 May 2011 11:45:05 -0600, Brian Paul<brianp at vmware.com> wrote:
>> or when piglit_link_simple_program() fails. Callers can then check
>> the return value to see if compiling/linking worked.
> I like it.
> I wonder, though, how many callers of the simple compile functions want
> anything but piglit_report_result(PIGLIT_FAIL) on compile/link failure?
> Having tests try to continue on rendering on failure sucks.
Yeah, I thought of that too. But I'm not sure of all the consequences
of going that far at this time. I think there might be a few callers
that are testing for zero (but would never actually get zero before
More information about the Piglit