[Piglit] [PATCH] piglit_util: return 0 when piglit_compile_shader_text() fails

Ian Romanick idr at freedesktop.org
Thu May 19 00:11:02 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/18/2011 09:37 PM, Eric Anholt wrote:
> On Wed, 18 May 2011 11:45:05 -0600, Brian Paul <brianp at vmware.com> wrote:
>> or when piglit_link_simple_program() fails.  Callers can then check
>> the return value to see if compiling/linking worked.
> 
> I like it.
> 
> I wonder, though, how many callers of the simple compile functions want
> anything but piglit_report_result(PIGLIT_FAIL) on compile/link failure?
> Having tests try to continue on rendering on failure sucks.

Aren't there some negative tests that use these functions?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk3UwoYACgkQX1gOwKyEAw8LRQCdECpYSXlH1oIbixWceCab+ZMo
uwsAoIrRP5zIa6DblwEn5ejEnK6MTyN9
=+1Zi
-----END PGP SIGNATURE-----


More information about the Piglit mailing list