[Piglit] [PATCH] new test : glsl-max-vertex-attrib.c

Brian Paul brianp at vmware.com
Wed May 25 08:45:43 PDT 2011

On 05/25/2011 04:18 AM, Tapani Pälli wrote:
> On 05/24/2011 04:46 PM, Brian Paul wrote:
>> On 05/24/2011 12:58 AM, tapani.palli at intel.com wrote:
>>> From: Tapani Pälli<tapani.palli at intel.com>
>>> Queries the value for GL_MAX_VERTEX_ATTRIBS and uses that as index
>>> to set a value with various functions. GL specification states that
>>> GL_INVALID_VALUE should occur if index>= GL_MAX_VERTEX_ATTRIBS.
>>> Refactored (no shader needed for this) and cleaned up the code + added
>>> missing copyright header.
>> Committed. Thanks.
>> Ideally, there are more functions that should be tested for this
>> error, but this hits the main ones.
> You are right, I have to admit that I was writing this test a bit too
> much from my actual application's perspective and the functions it
> uses and not inspecting the API headers. For GLES2 I missed these :
> glBindAttribLocation
> glDisableVertexAttribArray
> glEnableVertexAttribArray
> glGetActiveAttrib
> glGetAttribLocation
> glGetVertexAttribfv
> glGetVertexAttribiv
> glGetVertexAttribPointerv
> I will modify the test to include at least these, I'm not sure what
> are most relevant/important from the desktop side.

Can you provide a patch against the current test in git?


More information about the Piglit mailing list