[Piglit] [PATCH 0/4] refactor EGL test framework

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/24/2011 01:02 AM, Tapani Pälli wrote:
> Add config_attribs field to egl_test so that tests have to pass
> their wanted attributes for the EGL config selection. Now tests
> can pass any custom attributes for testing different features and
> behaviors with different configs.
> 
> I changed the existing tests to pass the attributes.
> 
> Tapani Pälli (4):
>   egl-util.h : add EGL config attributes to egl_test struct
>   egl-util.c : Remove hardcoded attributes, use attributes from    
>     egl_test structure. For existing tests to work correctly, call    
>     eglBindAPI when EGL_RENDERABLE_TYPE is set to EGL_OPENGL_BIT.
>   egl tests : pass wanted attributes for EGL config
>   egl-util.c : remove misleading doxygen comments
> 
>  tests/egl/egl-create-surface.c          |   11 +++++++++++
>  tests/egl/egl-nok-swap-region.c         |   11 +++++++++++
>  tests/egl/egl-nok-texture-from-pixmap.c |   11 +++++++++++
>  tests/egl/egl-util.c                    |   25 ++++++++-----------------
>  tests/egl/egl-util.h                    |    1 +
>  5 files changed, 42 insertions(+), 17 deletions(-)
> 

I think this is a good idea, and would like to see this implemented if
there exists some pending test that will use the functionality. For what
test case do you need to alter the EGLConfig, and spefically which
EGLConfig attributes do you need to alter?

See my comments on the individual patches.

- -- 
Chad Versace
chad at chad-versace.us
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJN4A/0AAoJEAIvNt057x8ivEcP/3xzuP/SDERChGBivpIEjLl4
tIlthG7UigjSEhZEpCq3rWzVxlaYNYDamy59vVyYJ+gBBVbPTaVevqvRwQ/WO/s9
waiTcjCObZ/v8k2XHzVF8FROXAxOA0cAs9tKO0n2eY6Y6bINL+bgEl0lEpEWZR9p
wumbK2G53N2VF6kLRyBX+rfxi8yv1PmrkaO3K75FgHkM+VfmxqA6zCbRk8ySUbs1
99k+xSjqYG6eCBcbFo/15Ks9bfwuq58HeWkyzuF5VZHA4ECQqfnLQ3LFI0Q2Id9X
GzYJ11lFfJ1vvvKq1V53ubBaF7dIwDtOXvtVVQw72lJCA7ExELxMF9OLrzBKIlmO
XOAd8g6ubX82F6WKiPW2HSp3h+mESXbafN6C2RnBK7yFV/RpAuSUWTs9pmXtMuNS
Ad1SZI/NxQwmsxMLUtz8L7TylvHI/ciEECuSgfsIaUD6ninvJcISTNHokaLE7PsD
l49RnRVOH7ciqszzsW4yqXq1wIpU83eSrE8YuNLwSTjVzOsKQ6COGIX/ION/IlGp
vvmlDjKqCWg/OmPbAKyNBN6My5/0ohAoz7NQQO7qLkxVCCnpuFfv5bn1OaPcHOcm
xOsCaGpwlwJUEUHuPigyxbkQmS9LzQCRKCJ3Xa90iIfFpQJ4ufY3wuzjCioQjd9w
sPOJPh/NmQ5/Zpm0K0GT
=vzDl
-----END PGP SIGNATURE-----