[Piglit] [PATCH] Test case on rendering with only fragment shader but no vertex shader.

Zhao, Jian J jian.j.zhao at intel.com
Thu Nov 3 02:44:00 PDT 2011


> -----Original Message-----
> From: Ian Romanick [mailto:idr at freedesktop.org]
> Sent: Thursday, November 03, 2011 5:27 AM
> To: Zhao, Jian J
> Cc: piglit at lists.freedesktop.org
> Subject: Re: [Piglit] [PATCH] Test case on rendering with only fragment
> shader but no vertex shader.
> 
> Hi guys.
> 
> As my comments in Mesa bug #42461 say, this test is just plain broken.
> Specifically, the call to piglit_ortho_projection causes the draw call
> to draw a quarter pixel at the lower left corner of the window.  Since
> the probe call checks the pixel in the middle of the window, it
> naturally fails.  Deleting the call to piglit_ortho_projection causes
> the test to pass.
> 
> For the time being, I'm going to NAK the whole test.  I think we need a
> comprehensive set of "missing" stage shader tests.  I don't think adding
> a single, one-off test now does much for us.  Does that seem reasonable?

Hi Ian, 
 Yes, you are right. Thanks for your help! 


Best regards
ZhaoJian



More information about the Piglit mailing list