[Piglit] [PATCH] glsl-1.30/execution/vertexid: New test for using gl_VertexID.

Chad Versace chad.versace at linux.intel.com
Wed Nov 9 09:44:31 PST 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/08/2011 07:14 PM, Eric Anholt wrote:
> A few different draw calls are tested to hopefully make sure the
> hardware is wired up like we expect.  Also, provide different vertex
> data and do a silly compare in each to be sure that we aren't
> accidentally using the wrong data for gl_VertexID due to miscellaneous
> bugs I could imagine.
> ---
>  tests/all.tests                                  |    1 +
>  tests/spec/glsl-1.30/execution/CMakeLists.gl.txt |    1 +
>  tests/spec/glsl-1.30/execution/vertexid.c        |  159 ++++++++++++++++++++++

The test looks correct, but I'd rather it be separated into three unit tests, one
for each type of draw call.

> +void
> +piglit_init(int argc, char **argv)
> +{
> +	GLuint vs, fs, prog;
> +
> +	piglit_require_GLSL();
> +	piglit_require_GLSL_version(130);

FYI, just the second call is needed. piglit_require_GLSL_version() internally
calls piglit_require_GLSL().

- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOurv6AAoJEAIvNt057x8iEscQAK/hqtPLEShD9IiZewxePI3X
0sf+gBce51ZxLssiE3XRYAnCTGODe/zA9gbTTiYiikYFzTpMZxLXXIRQQ0Wh68AT
AK5wj2lS9H8oGqNGt73eK/J6NLEGcer9TqEAyvPvKEdCMpKzz0MCtGhwQ8vRdOeU
d46WhThhTId555FTKTA8cG09eOeQSUtf/oBtc9EsZ07HtQq3qvgJIIDLbu8wXE/K
vu7gb33QIV9r6UBOOz1fa8o3+LRHGxnBPPhoNQVQf6MEhIB0nqRcyBmH6ENCDOf5
aDDDSllDzQaKWhHc9ydaBYoLpmmTwezBkpti5fAkTs803s8Orf4VCa72VYijgwIh
45pFS936h9em/D1RN/qSqiEFZX/LedlyO3hbmN32qn0Cj63ZI8rgKreRD0UL2pnA
FbcoQOijlmEYU5Km3uvbVKH7gq6z9jsyiErKrqjwdAKskx33HbxqeUxGQG7WQd9j
jqngEEtcOMpOgqR281m5pYmHKVjBby5lq8aLTwyHmjtyS6OuNf7FZeU55Kku6k3D
4AOz+HyKD6SekqJztSdBjv5KQXlL4/FRgW7GAk1GCGtbSE2khKYGvUzDyojhHHdW
RhtRmFjPAjSP0cI52j6ellgcgwaTkkYqlxg4Je4bK0eA55mbAzmHCXhVemk5UJCe
i+k86Fy5LtKTHoAZvSJG
=DGnG
-----END PGP SIGNATURE-----


More information about the Piglit mailing list