[Piglit] [PATCH 1/2] gl-3.0/required-sized-formats: New test for GL3.0.

Eric Anholt eric at anholt.net
Wed Nov 9 17:15:50 PST 2011


On Mon, 07 Nov 2011 09:37:52 -0800, Ian Romanick <idr at freedesktop.org> wrote:
> On 11/06/2011 08:32 PM, Eric Anholt wrote:
> 
> Does this test pass on any of the closed-source drivers?  Since it uses 
> floating-point depth textures, I assume it doesn't pass on Mesa yet.
> 
> > ---
> >   tests/all.tests                            |    1 +
> >   tests/spec/gl-3.0/CMakeLists.gl.txt        |   17 ++
> >   tests/spec/gl-3.0/required-sized-formats.c |  414 ++++++++++++++++++++++++++++
> 
> I have some tests outstanding that put things in tests/spec/gl-3.0/api. 
>   I think this test should go in tests/spec/gl-3.0/fbo or 
> tests/spec/gl-3.0/texture.  I assume we'll have a similar test that 
> tries to create FBOs in all of the required format combinations.

In other news, I've decided to totally rework this so I can share the
big annoying table with the 3.0 attachment tests, and between GL
versions, and with another test I want to do for non-mandated
internalsizes.

> > +enum piglit_result
> > +piglit_display(void)
> > +{
> > +	bool pass = true;
> > +	float green[4] = {0.0, 1.0, 0.0, 0.0};
> > +	float red[4] = {1.0, 0.0, 0.0, 0.0};
> > +
> > +	glDisable(GL_RASTERIZER_DISCARD);
> > +	glClearBufferfv(GL_COLOR, 0, green);
> > +
> > +	glEnable(GL_RASTERIZER_DISCARD);
> > +	glClearBufferfv(GL_COLOR, 0, red);
> > +
> > +	pass = piglit_probe_rect_rgba(0, 0, piglit_width, piglit_height, green);
> > +
> > +	glutSwapBuffers();
> > +
> > +	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
> 
> Is this copy-and-pasted from another test?  Since the real test happesn 
> in piglit_init, it seems like this should be the usual 'return 
> PIGLIT_FAIL;' version of piglit_display.

Yeah, it was just copied from a test next to it and I forgot to delete.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111109/4f8f79ac/attachment.pgp>


More information about the Piglit mailing list