[Piglit] [PATCH 1/2] Fix redundant static-write-varying-01.frag tests.

Paul Berry stereotype441 at gmail.com
Thu Nov 10 11:38:25 PST 2011


When the static-write-varying-01.frag tests were introduced, they were
accidentally made the same as the corresponding
static-write-varying-02.frag.

The original intent (from talking to Chad) was for one set of tests
verify that varyings can't be written to via direct assignment, and
the other set of tests to verify that varyings can't be written to via
passing to a function as an "out" parameter.

This patch updates static-write-varying-01.frag to reflect the
original intent.
---
 .../storage-qualfiers/static-write-varying-01.frag |    6 +-----
 .../storage-qualfiers/static-write-varying-01.frag |    6 +-----
 .../storage-qualfiers/static-write-varying-01.frag |    6 +-----
 3 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag b/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag
index e5548c5..aedbc02 100644
--- a/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag
+++ b/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag
@@ -10,10 +10,6 @@
 
 varying float x;
 
-void f(out float y) {
-    y = 0.0;
-}
-
 void g() {
-    f(x);
+    y = 0.0;
 }
diff --git a/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag b/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag
index 11b5834..48f54d0 100644
--- a/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag
+++ b/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag
@@ -10,10 +10,6 @@
 
 varying float x;
 
-void f(out float y) {
-    y = 0.0;
-}
-
 void g() {
-    f(x);
+    x = 0.0;
 }
diff --git a/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag b/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag
index 1e03f27..ec832f9 100644
--- a/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag
+++ b/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag
@@ -10,10 +10,6 @@
 
 varying float x;
 
-void f(out float y) {
-    y = 0.0;
-}
-
 void g() {
-    f(x);
+    y = 0.0;
 }
-- 
1.7.6.4



More information about the Piglit mailing list