[Piglit] [PATCH] glsl: Add tests for glGetActiveAttrib

[Eric Anholt]

On Wed, 23 Nov 2011 13:13:34 -0800, "Ian Romanick" <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Verify that glGetActiveAttrib and GL_ACTIVE_ATTRIBUTES return sensible
> data under a variety of circumstances.  There are checks for all the
> types and built-in attributes in GLSL 1.10, 1.20, and 1.30.
> 
> All of the subcases pass on NVIDIA's closed-source Linux driver and
> AMD's closed-source Linux driver.
> 
> These test fails horribly on Mesa 7.11.  Matrix attributes are
> reported multiple times (once per column of the matrix) and built-in
> attributes are never reported.  Mesa master fixes the matrix issues,
> but it still has problems with built-in attributes.  There is a patch
> on the mesa-dev mailing list to fix that issue.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43138

> +struct test {
> +	const char *code;
> +
> +	unsigned num_attributes;
> +
> +	struct attribute attributes[16];
> +};

Couldn't num_attributes be dropped and just use attributes[].name !=
NULL to see if it's in use?  It would clean up the tests list setup.

Looks like a great test, though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111127/b0bcf678/attachment.pgp>