[Piglit] [PATCH] Add test to verify glCopyPixels()

[Brian Paul]

On 04/02/2012 04:58 AM, Anuj Phogat wrote:
> This test varifies glCopyPixels() with GL_COLOR, GL_DEPTH and GL_STENCIL
>
> Signed-off-by: Anuj Phogat<anuj.phogat at gmail.com>
> ---
>   tests/all.tests                 |    1 +
>   tests/general/CMakeLists.gl.txt |    1 +
>   tests/general/copy-pixels.c     |  103 +++++++++++++++++++++++++++++++++++++++
>   3 files changed, 105 insertions(+), 0 deletions(-)
>   create mode 100644 tests/general/copy-pixels.c
>
> diff --git a/tests/all.tests b/tests/all.tests
> index 5b3dc6b..403b997 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -227,6 +227,7 @@ add_plain_test(general, 'bgra-vert-attrib-pointer')
>   add_plain_test(general, 'blendminmax')
>   add_plain_test(general, 'blendsquare')
>   add_plain_test(general, 'clear-varray-2.0')
> +add_plain_test(general, 'copy-pixels')
>   add_plain_test(general, 'copypixels-draw-sync')
>   add_plain_test(general, 'copypixels-sync')
>   add_plain_test(general, 'depthrange-clear')
> diff --git a/tests/general/CMakeLists.gl.txt b/tests/general/CMakeLists.gl.txt
> index 95f8819..ef3deff 100644
> --- a/tests/general/CMakeLists.gl.txt
> +++ b/tests/general/CMakeLists.gl.txt
> @@ -18,6 +18,7 @@ add_executable (bgra-sec-color-pointer bgra-sec-color-pointer.c)
>   add_executable (blendminmax blendminmax.c)
>   add_executable (blendsquare blendsquare.c)
>   add_executable (clear-varray-2.0 clear-varray-2.0.c)
> +add_executable (copy-pixels copy-pixels.c)
>   add_executable (copypixels-sync copypixels-sync.c)
>   add_executable (copypixels-draw-sync copypixels-draw-sync.c)
>   add_executable (depth-clamp-range depth-clamp-range.c)
> diff --git a/tests/general/copy-pixels.c b/tests/general/copy-pixels.c
> new file mode 100644
> index 0000000..80c2988
> --- /dev/null
> +++ b/tests/general/copy-pixels.c
> @@ -0,0 +1,103 @@
> +/*
> + * Copyright © 2011 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +/**
> + * @file copy-pixels.c
> + *
> + * Test to verify glCopyPixels with GL_COLOR, GL_DEPTH and GL_STENCIL
> + *
> + * Author: Anuj Phogat
> + */
> +
> +#include "piglit-util.h"
> +#include "piglit-framework.h"
> +
> +int piglit_width = 32;
> +int piglit_height = 32;
> +int piglit_window_mode = GLUT_RGBA | GLUT_DOUBLE | GLUT_ALPHA |
> +			 GLUT_STENCIL | GLUT_DEPTH;
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> +	int i, j;
> +	float buf[16][16];
> +	float depth_val = 0.75, stencil_val = 2.0;
> +	float green[4] = {0.0, 1.0, 0.0, 0.0};
> +	bool pass = true;
> +
> +	glClearColor(0.0, 0.0, 0.0, 1.0);
> +	glClear(GL_COLOR_BUFFER_BIT);
> +
> +	glColor4fv(green);
> +	piglit_draw_rect(0, 0, 16, 16);
> +
> +	glRasterPos2i(16, 16);
> +	glCopyPixels(0, 0, 16, 16, GL_COLOR);
> +	pass = pass&&  piglit_probe_rect_rgba(16, 16, 16, 16, green);
> +
> +	/* Initialize depth data */
> +	for (i = 0; i<  16; i++) {
> +		for(j = 0; j<  16; j++)
> +			buf[i][j] = depth_val;
> +	}
> +
> +	glClearDepth(0.0);
> +	glClear(GL_DEPTH_BUFFER_BIT);
> +	glEnable(GL_DEPTH_TEST);
> +	glDepthFunc(GL_ALWAYS);
> +
> +	glRasterPos2i(0, 0);
> +	glDrawPixels(16, 16,
> +		     GL_DEPTH_COMPONENT, GL_FLOAT, buf);
> +	glRasterPos2i(16, 16);
> +	glCopyPixels(0, 0, 16, 16, GL_DEPTH);
> +	pass = piglit_probe_rect_depth(16, 16, 16, 16, depth_val)
> +	&&  pass;
> +
> +	/* Initialize stencil data */
> +	for (i = 0; i<  16; i++) {
> +		for(j = 0; j<  16; j++)
> +			buf[i][j] = stencil_val;
> +	}
> +
> +	glClearStencil(0.0);
> +	glClear(GL_STENCIL_BUFFER_BIT);
> +
> +	glRasterPos2i(0, 0);
> +	glDrawPixels(16, 16,
> +		     GL_STENCIL_INDEX, GL_FLOAT, buf);
> +	glRasterPos2i(16, 16);
> +	glCopyPixels(0, 0, 16, 16, GL_STENCIL);
> +	pass = piglit_probe_rect_stencil(16, 16, 16, 16, stencil_val)
> +	&&  pass;

There's a lot of hardcoded 16s.  Maybe define some local vars like x, 
y, width, height and use them in the appropriate places.  I think that 
would improve readability.  As for debugging, it might be nice to use 
different values for positions and sizes to minimize confusion.

> +
> +	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
> +}
> +
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> +	piglit_ortho_projection(piglit_width, piglit_height, GL_FALSE);
> +}


-Brian