[Piglit] [PATCH] Add test to verify glDrawPixels with allowed pixel formats and data types

Brian Paul brianp at vmware.com
Thu Apr 12 08:30:16 PDT 2012


On 04/12/2012 09:18 AM, Brian Paul wrote:

> Looks OK otherwise. But I'm seeing some failures with Mesa for the
> ubyte 332 and 233 cases. Ex:
>
> Format = GL_RGB, Type = GL_UNSIGNED_BYTE_2_3_3_REV, Swap Bytes = 0
> Probe at (0,0)
> Expected: 0.142857 0.428571 0.666667 1.000000
> Observed: 0.133333 0.400000 0.666667 1.000000
>
> Could you look into those?

It looks like swrast is OK but softpipe/llvmpipe are failing.

I think you just need to loosen the tolerance a little bit when 
testing 3- and 2-bit channels.

You can call the piglit_set_tolerance_for_bits() function to do that.

-Brian


More information about the Piglit mailing list