[Piglit] [PATCH] Add a test of the accuracy of MSAA rendering.
stereotype441 at gmail.com
Mon Apr 23 08:56:50 PDT 2012
On 19 April 2012 08:00, Paul Berry <stereotype441 at gmail.com> wrote:
> On 19 April 2012 06:41, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>> On Thu, Apr 19, 2012 at 12:09 AM, Paul Berry <stereotype441 at gmail.com>wrote:
> Everyone: I'm interested in hearing
>>> opinions about whether this test is too big, and if so, how to
>>> effectively split it up into smaller tests.
>> This is a fairly comprehensive test to measure the accuracy of MSAA in
>> I liked the way you are generating reference image. In my opinion there
>> are lot
>> of functions in this test which could be utilized by upcoming multisample
>> cases. e.g. the current piglit test I'm working on (Test switching MSAA
>> on/off in
>> FBO), can utilize draw_reference_image() and measure_accuracy() functions
>> verify if MSAA is actually switched ON in FBO. Every new multisample test
>> would require these functions to verify if MSAA is happening as expected.
>> So, it would be helpful to split it in to two files: common.cpp,
> That's a good thought. I'll try to figure out a sensible way to factor
> out the reusable stuff into a separate file.
After further reflection, it's not obvious to me how to refactor out the
reusable parts of the test without a better understanding of how other
tests will re-use the functionality. So I think I'd prefer to push the
code as is, and then refactor it incrementally as we discover what parts
are useful to other tests. If there are no objections to that, I'll go
ahead and push the code tomorrow morning.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Piglit