[Piglit] [PATCH] glsl-fs-user-varying-ff: make the result more reliable

Eric Anholt eric at anholt.net
Fri Aug 31 14:00:43 PDT 2012


Vadim Girlin <vadimgirlin at gmail.com> writes:

> The test is not reliable, because in the "correct" case the result is 
> "undefined" and the test tries to check it by comparing it with some constant.
> "undefined" value _probably_ will not be equal, but it still could be equal. The
> test randomly fails sometimes with r600g.
>
> Decreases probability of the false fail by probing the whole drawn rectangle
> instead of a single pixel.

If it's an undefined value, I think we should just verify that the
program runs to completion (do a readpixels, throw out the result)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120831/667e399a/attachment.pgp>


More information about the Piglit mailing list