[Piglit] [PATCH] glsl-fs-user-varying-ff: ignore probing result

Vadim Girlin vadimgirlin at gmail.com
Fri Aug 31 16:06:23 PDT 2012


The test is not very reliable, because it checks if the result is
"undefined" by comparing it with some constant. "undefined" value
_probably_ will not be equal, but it still could be equal.

Fixes random fails with r600g.
---

Btw, I think I don't have commit access for piglit, if it's not the same as for
mesa. If so, could somebody please push this patch (if there are no objections,
of course).

 tests/shaders/glsl-fs-user-varying-ff.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/shaders/glsl-fs-user-varying-ff.c b/tests/shaders/glsl-fs-user-varying-ff.c
index e1143ab..9cd6703 100644
--- a/tests/shaders/glsl-fs-user-varying-ff.c
+++ b/tests/shaders/glsl-fs-user-varying-ff.c
@@ -59,8 +59,7 @@ piglit_display(void)
 	/* The vertex shader is passing green to the fragment shader in an
 	 * illegal way.  The rendered result must not be green!
 	 */
-	if (piglit_probe_pixel_rgb(15, 15, green))
-		result = PIGLIT_FAIL;
+	piglit_probe_pixel_rgb(15, 15, green);
 
 	if (!piglit_automatic)
 		glutSwapBuffers();
-- 
1.7.11.4



More information about the Piglit mailing list