[Piglit] [PATCH 1/1] Clean up shader_runner test scripts.

Stuart Abercrombie sabercrombie at chromium.org
Tue Dec 4 13:38:32 PST 2012

>> 1) I neeeded to change the shell command to get it to even run.

I'll separate out the /bin/sh -> /bin/bash changes.

>> 2) I was then able to modify the script to fix the version stuff like I
>> originally wanted to.

I'll send in a separate patch to fix the broken GLSL version
outputting in variable-index-write.sh.

>> 3) After I did so, I found that one of my scripts couldn't parse one of
>> the files.

I'm fine leaving that file in an inconsistent state with everything else.

> I couldn't understand why that last patch (unsigned->int) mattered.  Did
> it fix a compile warning or something?

>From previous reviews I had the impression that there was a desire for
type consistency.  I could submit it as part of another patch.  Or is
that a bad idea?


More information about the Piglit mailing list