[Piglit] [PATCH 2/5] gles2: new glReadPixels unit test

Tom Gall tom.gall at linaro.org
Thu Dec 20 17:03:20 PST 2012

Hi Matt,

Thanks for the input.

On Thu, Dec 20, 2012 at 1:57 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Thu, Dec 20, 2012 at 10:54 AM, Tom Gall <tom.gall at linaro.org> wrote:
>> A few variations are commented out due to results that are
>> incorrect and need to be followed up with Mesa, such as modifying
>> the buffer even tho the format is invalid. There are cases where
>> the returned data is incorrectly formated. These can best be
>> addressed in time and I thought it best to include the variations
>> but in their commented out form.
> I think Eric already told you that it's okay to commit failing tests.

It was Ian that had mentioned that as I recall. I guess I can
uncomment them out but I'm less than excited about that for the
reasons I outlined.

Anyway, I see a couple of warts in the patch. Shall fix that up and
uncomment out the other bits.



"Where's the kaboom!? There was supposed to be an earth-shattering
kaboom!" Marvin Martian
Graphics Working Group | Linaro.org │ Open source software for ARM SoCs
w) tom.gall att linaro.org
h) tom_gall att mac.com

More information about the Piglit mailing list