[Piglit] [PATCH] tex3d-maxsize: remove unused NVIDIA hack code

Jose Fonseca jfonseca at vmware.com
Tue Feb 28 02:52:08 PST 2012


LGTM.

Jose

----- Original Message -----
> The problem described in the comments no longer seems to be an issue
> with a recent driver.
> ---
>  tests/texturing/tex3d-maxsize.c |   12 +-----------
>  1 files changed, 1 insertions(+), 11 deletions(-)
> 
> diff --git a/tests/texturing/tex3d-maxsize.c
> b/tests/texturing/tex3d-maxsize.c
> index 4d10d09..dd576e4 100644
> --- a/tests/texturing/tex3d-maxsize.c
> +++ b/tests/texturing/tex3d-maxsize.c
> @@ -110,17 +110,7 @@ piglit_display(void)
>  
>  		/* use proxy texture to find working max texture size */
>  		find_max_tex3d_size(maxsize, &width, &height, &depth);
> -#ifdef NVIDIA_HACK
> -		/* XXX NVIDIA's proxy texture mechanism is broken.
> -		 * If this code is enabled, a smaller texture is used and
> -		 * the test passes.  Only halving the texture size isn't enough:
> -		 * we try to allocate a gigantic texture which typically brings
> -		 * the machine to its knees, swapping, then dying.
> -		 */
> -		width /= 4;
> -		height /= 4;
> -		depth /= 4;
> -#endif
> +
>  		glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA8, width, height, depth, 0,
>  			     GL_RGBA, GL_UNSIGNED_BYTE, NULL);
>  		err = glGetError();
> --
> 1.7.3.4
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
> 


More information about the Piglit mailing list