[Piglit] [PATCH] [v6] Add test case of error check on glGetTexImage.

Brian Paul brianp at vmware.com
Mon Jan 2 06:48:25 PST 2012

On 12/29/2011 02:54 AM, Jian Zhao wrote:
> Add test case on error check on glGetTexImage with types(like
> GL_UNSIGNED_INT_10F_11F_11F_REV) that only work with format GL_RGB, but format
> isn't GL_RGB the result should be GL_INVALID_OPERATION.
> As glGetTexImage in OpenGL 4.2 Reference Pages:
> "GL_INVALID_OPERATION is returned if type is one of GL_UNSIGNED_BYTE_3_3_2,
> GL_UNSIGNED_SHORT_5_6_5_REV, or GL_UNSIGNED_INT_10F_11F_11F_REV and format is
> not GL_RGB".
> v2: change the test name to be more specific and change some code style to be
> easier to read (per Brian's suggest).
> v3: move the case to the spec directory and rename it to
> getteximage_error_check.c. (per Brian's suggest)
> v4: add all the formats that only work with GL_RGB format, rename it more
> specific and some minor changes. (per Ian's suggest)
> v5: some changes in code styles, like "One space on either side of a binary operator or =". (per Ian's suggest)
> v6: fix all the indention issues. (per yuanhan's suggest)
> Signed-off-by: Jian Zhao<jian.j.zhao at intel.com>
> Reviewed-by: Brian Paul<brianp at vmware.com>
> Reviewed-by: Yuanhan Liu<yuanhan.liu at linux.intel.com>

Looks good. (already reviewed-by).


More information about the Piglit mailing list