[Piglit] [PATCH] framework: Don't override result to 'fail' on returncode != 0.

Kenneth Graunke kenneth at whitecape.org
Mon Jan 2 13:59:04 PST 2012


We do want to override interpretResult() for crashes, but not for generic
failures.  So default to 'fail', call interpretResult(), then check for
crashes.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 framework/exectest.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/framework/exectest.py b/framework/exectest.py
index d783fa5..04b0d3e 100644
--- a/framework/exectest.py
+++ b/framework/exectest.py
@@ -78,6 +78,7 @@ class ExecTest(Test):
 
 			results = TestResult()
 
+			results['result'] = 'fail'
 			out = self.interpretResult(out, results)
 
 			if proc.returncode == -5:
@@ -95,7 +96,6 @@ class ExecTest(Test):
 				# Windows EXCEPTION_INT_DIVIDE_BY_ZERO
 				results['result'] = 'crash'
 			elif proc.returncode != 0:
-				results['result'] = 'fail'
 				results['note'] = 'Returncode was %d' % (proc.returncode)
 
 			env = ''
-- 
1.7.8.1



More information about the Piglit mailing list