[Piglit] [PATCH] incomplete-texture: test sampling from an incomplete texture object

[Eric Anholt]

On Thu,  5 Jan 2012 08:56:10 -0700, Brian Paul <brianp at vmware.com> wrote:
> v2: take a command line parameter for fixed vs. ARB_fp vs. GLSL mode.
> v3: make concurrent, probe rect, use piglit_require_GLSL_version()

> ---
>  tests/all.tests                      |    8 +
>  tests/texturing/CMakeLists.gl.txt    |    1 +
>  tests/texturing/incomplete-texture.c |  306 ++++++++++++++++++++++++++++++++++
>  3 files changed, 315 insertions(+), 0 deletions(-)
>  create mode 100644 tests/texturing/incomplete-texture.c
> 
> diff --git a/tests/all.tests b/tests/all.tests
> index 8390e87..d281abb 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -660,6 +660,14 @@ add_plain_test(texturing, 'gen-nonzero-unit')
>  add_plain_test(texturing, 'gen-texsubimage')
>  add_plain_test(texturing, 'getteximage-formats')
>  add_plain_test(texturing, 'getteximage-simple')
> +
> +texturing['incomplete-texture-fixed'] = PlainExecTest(['incomplete-texture', '-auto', 'fixed'])
> +texturing['incomplete-texture-fixed'].runConcurrent = True
> +texturing['incomplete-texture-arb_fp'] = PlainExecTest(['incomplete-texture', '-auto', 'arb_fp'])
> +texturing['incomplete-texture-arb_fp'].runConcurrent = True
> +texturing['incomplete-texture-glsl'] = PlainExecTest(['incomplete-texture', '-auto', 'glsl'])
> +texturing['incomplete-texture-glsl'].runConcurrent = True

I think you're looking for

texturing['incomplete-texture-glsl'] = concurrent_test('incomplete-texture -auto glsl')

> +	if (Tests & TEST_ARB_FP) {
> +		if (!piglit_is_extension_supported("GL_ARB_fragment_program")) {
> +			piglit_report_result(PIGLIT_SKIP);
> +		}
> +		pass = test_arb_fp() && pass;

piglit_require_extension("GL_ARB_fragment_program")

> +	}
> +
> +	if (Tests & TEST_GLSL) {
> +		piglit_require_GLSL_version(110);
> +		pass = test_glsl() && pass;
> +	}

Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120105/f1ddaf9f/attachment.pgp>