[Piglit] [PATCH] incomplete-texture: test sampling from an incomplete texture object

[Brian Paul]

On 01/05/2012 09:55 AM, Eric Anholt wrote:
> On Thu,  5 Jan 2012 08:56:10 -0700, Brian Paul<brianp at vmware.com>  wrote:
>> v2: take a command line parameter for fixed vs. ARB_fp vs. GLSL mode.
>> v3: make concurrent, probe rect, use piglit_require_GLSL_version()
>
>> ---
>>   tests/all.tests                      |    8 +
>>   tests/texturing/CMakeLists.gl.txt    |    1 +
>>   tests/texturing/incomplete-texture.c |  306 ++++++++++++++++++++++++++++++++++
>>   3 files changed, 315 insertions(+), 0 deletions(-)
>>   create mode 100644 tests/texturing/incomplete-texture.c
>>
>> diff --git a/tests/all.tests b/tests/all.tests
>> index 8390e87..d281abb 100644
>> --- a/tests/all.tests
>> +++ b/tests/all.tests
>> @@ -660,6 +660,14 @@ add_plain_test(texturing, 'gen-nonzero-unit')
>>   add_plain_test(texturing, 'gen-texsubimage')
>>   add_plain_test(texturing, 'getteximage-formats')
>>   add_plain_test(texturing, 'getteximage-simple')
>> +
>> +texturing['incomplete-texture-fixed'] = PlainExecTest(['incomplete-texture', '-auto', 'fixed'])
>> +texturing['incomplete-texture-fixed'].runConcurrent = True
>> +texturing['incomplete-texture-arb_fp'] = PlainExecTest(['incomplete-texture', '-auto', 'arb_fp'])
>> +texturing['incomplete-texture-arb_fp'].runConcurrent = True
>> +texturing['incomplete-texture-glsl'] = PlainExecTest(['incomplete-texture', '-auto', 'glsl'])
>> +texturing['incomplete-texture-glsl'].runConcurrent = True
>
> I think you're looking for
>
> texturing['incomplete-texture-glsl'] = concurrent_test('incomplete-texture -auto glsl')

Hmmm, this leads to a weird failure.  When I made that change I 
started seeing this in the log file:

  "errors": [
                     "freeglut  ERROR:  Function <glutReshapeFunc> 
called without first calling 'glutInit'."


I verified with gdb that glutInit() is indeed being called first.

In any case, I can remove the glutReshapeFunc() call and work around 
it.  I don't have time to debug it further.


>> +	if (Tests&  TEST_ARB_FP) {
>> +		if (!piglit_is_extension_supported("GL_ARB_fragment_program")) {
>> +			piglit_report_result(PIGLIT_SKIP);
>> +		}
>> +		pass = test_arb_fp()&&  pass;
>
> piglit_require_extension("GL_ARB_fragment_program")

OK.

>
>> +	}
>> +
>> +	if (Tests&  TEST_GLSL) {
>> +		piglit_require_GLSL_version(110);
>> +		pass = test_glsl()&&  pass;
>> +	}
>
> Other than that,
>
> Reviewed-by: Eric Anholt<eric at anholt.net>

Thanks.

-Brian