[Piglit] [PATCH] Move EXT_transform_feedback check

Paul Berry stereotype441 at gmail.com
Thu Jan 19 16:15:06 PST 2012


On 19 January 2012 15:15, Ian Romanick <idr at freedesktop.org> wrote:

> From: Ian Romanick <ian.d.romanick at intel.com>
>
> The check occured too late in some invocations.  This caused the test
> to fail on platforms that don't support EXT_transform_feedback when it
> should be skipped.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  tests/spec/ext_transform_feedback/generatemipmap.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/tests/spec/ext_transform_feedback/generatemipmap.c
> b/tests/spec/ext_transform_feedback/generatemipmap.c
> index 1fe035c..2f16e1c 100644
> --- a/tests/spec/ext_transform_feedback/generatemipmap.c
> +++ b/tests/spec/ext_transform_feedback/generatemipmap.c
> @@ -274,10 +274,11 @@ void piglit_init(int argc, char **argv)
>        else
>                print_usage_and_exit(argv[0]);
>
> +       piglit_require_transform_feedback();
> +
>        if (buffer || prims_written) {
>                GLuint vs;
>                piglit_require_GLSL();
> -               piglit_require_transform_feedback();
>                vs = piglit_compile_shader_text(GL_VERTEX_SHADER, vstext);
>                xfb_prog = piglit_CreateProgram();
>                piglit_AttachShader(xfb_prog, vs);
> --
> 1.7.6.4
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>

Oops.  You're right of course.

Reviewed-by: Paul Berry <stereotype441 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120119/1b9f2feb/attachment.html>


More information about the Piglit mailing list