[Piglit] [PATCH 4/7] glx_ext_create_context_es2_profile: Verify that indirect-rendering is impossible
Ian Romanick
idr at freedesktop.org
Wed Jul 4 14:25:34 PDT 2012
From: Ian Romanick <ian.d.romanick at intel.com>
The spec doesn't forbid indirect rendering with OpenGL ES 2.0.
There's no protocol defined, so it seems impossible that this could
ever work.
NVIDIA's closed-source driver fails this test because an unusable
indirect-rendering ES2 context is created.
AMD's closed-source driver has not been tested.
v2: The test will pass if the indirect-rendering context can actually
be used. For this we require that glGetShaderPrecisionFormat produce
a valid result.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Cc: James Jones <jajones at nvidia.com>
Cc: Chad Versace <chad.versace at linux.intel.com>
---
tests/all.tests | 4 +
.../spec/glx_arb_create_context/CMakeLists.gl.txt | 1 +
.../glx_arb_create_context/indirect-es2-profile.c | 115 ++++++++++++++++++++
3 files changed, 120 insertions(+), 0 deletions(-)
create mode 100644 tests/spec/glx_arb_create_context/indirect-es2-profile.c
diff --git a/tests/all.tests b/tests/all.tests
index 37a7453..a16d930 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -708,6 +708,10 @@ create_context_profile['3.2 core profile required'] = PlainExecTest(['glx-create
create_context_profile['invalid profile'] = PlainExecTest(['glx-create-context-invalid-profile'])
create_context_profile['pre-GL3 profile'] = PlainExecTest(['glx-create-context-pre-GL3-profile'])
+create_context_es2_profile = Group();
+glx['GLX_EXT_create_context_es2_profile'] = create_context_es2_profile
+create_context_es2_profile['indirect rendering ES2 profile'] = PlainExecTest(['glx-create-context-indirect-es2-profile'])
+
texturing = Group()
add_concurrent_test(texturing, '1-1-linear-texture')
add_plain_test(texturing, 'array-texture')
diff --git a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
index 5b78843..e64f410 100644
--- a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
+++ b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
@@ -25,6 +25,7 @@ IF(BUILD_GLX_TESTS)
piglit_add_executable (glx-create-context-core-profile core-profile.c common.c)
piglit_add_executable (glx-create-context-default-major-version default-major-version.c common.c)
piglit_add_executable (glx-create-context-default-minor-version default-minor-version.c common.c)
+ piglit_add_executable (glx-create-context-indirect-es2-profile indirect-es2-profile.c common.c)
piglit_add_executable (glx-create-context-invalid-attribute invalid-attribute.c common.c)
piglit_add_executable (glx-create-context-invalid-flag invalid-flag.c common.c)
piglit_add_executable (glx-create-context-invalid-flag-forward-compatible invalid-flag-forward-compatible.c common.c)
diff --git a/tests/spec/glx_arb_create_context/indirect-es2-profile.c b/tests/spec/glx_arb_create_context/indirect-es2-profile.c
new file mode 100644
index 0000000..ad2e810
--- /dev/null
+++ b/tests/spec/glx_arb_create_context/indirect-es2-profile.c
@@ -0,0 +1,115 @@
+/* Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+#include "piglit-util.h"
+#include "piglit-glx-util.h"
+#include "common.h"
+
+int main(int argc, char **argv)
+{
+ static const int attribs[] = {
+ GLX_CONTEXT_MAJOR_VERSION_ARB,
+ 2,
+ GLX_CONTEXT_MINOR_VERSION_ARB,
+ 0,
+ GLX_CONTEXT_PROFILE_MASK_ARB,
+ GLX_CONTEXT_ES2_PROFILE_BIT_EXT,
+ None
+ };
+
+ bool pass = true;
+ GLXContext ctx;
+
+ GLX_ARB_create_context_setup();
+ piglit_require_glx_extension(dpy, "GLX_ARB_create_context_profile");
+ piglit_require_glx_extension(dpy, "GLX_EXT_create_context_es2_profile");
+
+ /* The GLX_EXT_create_context_es2_profile doesn't say anything about
+ * indirect-rendering contexts for ES2. However, there is no protocol
+ * defined, so it seems impossible that this could ever work.
+ */
+ ctx = glXCreateContextAttribsARB(dpy, fbconfig, NULL, False, attribs);
+ XSync(dpy, 0);
+
+ if (ctx != NULL) {
+ PFNGLGETSHADERPRECISIONFORMATPROC func;
+ GLint r[] = { ~0, ~0 };
+ GLint p = ~0;
+
+ /* Try to call an ES2 function that does not exist in desktop
+ * OpenGL or have GLX protocol defined. If this works, then
+ * we'll assume the implementation is using some magic
+ * protocol for ES2. If it doesn't work, then the test fails.
+ */
+ func = (PFNGLGETSHADERPRECISIONFORMATPROC)
+ glXGetProcAddress((const GLubyte *)
+ "glGetShaderPrecisionFormat");
+ if (func == NULL) {
+ fprintf(stderr,
+ "Indirect rendering OpenGL ES 2.0 context was "
+ "created, but could not get\n"
+ "function address for "
+ "glGetShaderPrecisionFormat.\n");
+ pass = false;
+ goto done;
+ }
+
+ if (!glXMakeCurrent(dpy, glxWin, ctx)) {
+ fprintf(stderr,
+ "Indirect rendering OpenGL ES 2.0 "
+ "context was created, but\n"
+ "it could not be made current.\n");
+ pass = false;
+ goto done;
+ }
+
+ (*func)(GL_VERTEX_SHADER, GL_MEDIUM_FLOAT, r, &p);
+ if (r[0] < 14 || r[1] < 14 || p < 16) {
+ fprintf(stderr,
+ "Indirect rendering OpenGL ES 2.0 "
+ "context was created, but\n"
+ "glGetShaderPrecisionFormat produced "
+ "incorrect results.\n");
+ pass = false;
+ }
+ } else {
+ /* The GLX_ARB_create_context_profile spec says:
+ *
+ * "* If <config> does not support compatible OpenGL
+ * contexts providing the requested API major and minor
+ * version, forward-compatible flag, and debug context
+ * flag, GLXBadFBConfig is generated."
+ */
+ if (!validate_glx_error_code(Success, GLXBadFBConfig))
+ pass = false;
+ }
+
+done:
+ if (ctx != NULL) {
+ glXMakeCurrent(dpy, None, NULL);
+ glXDestroyContext(dpy, ctx);
+ }
+
+ GLX_ARB_create_context_teardown();
+
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+ return 0;
+}
--
1.7.6.5
More information about the Piglit
mailing list