[Piglit] [PATCH 4/7] glx_ext_create_context_es2_profile: Verify that indirect-rendering is impossible

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/04/2012 02:25 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> The spec doesn't forbid indirect rendering with OpenGL ES 2.0. There's no
> protocol defined, so it seems impossible that this could ever work.
> 
> NVIDIA's closed-source driver fails this test because an unusable 
> indirect-rendering ES2 context is created.
> 
> AMD's closed-source driver has not been tested.
> 
> v2: The test will pass if the indirect-rendering context can actually be
> used.  For this we require that glGetShaderPrecisionFormat produce a valid
> result.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com> Cc: James Jones
> <jajones at nvidia.com> Cc: Chad Versace <chad.versace at linux.intel.com> --- 
> tests/all.tests                                    |    4 + 
> .../spec/glx_arb_create_context/CMakeLists.gl.txt  |    1 + 
> .../glx_arb_create_context/indirect-es2-profile.c  |  115
> ++++++++++++++++++++ 3 files changed, 120 insertions(+), 0 deletions(-) 
> create mode 100644
> tests/spec/glx_arb_create_context/indirect-es2-profile.c

The overall test looks good, but...

> +		(*func)(GL_VERTEX_SHADER, GL_MEDIUM_FLOAT, r, &p); +		if (r[0] < 14 ||
> r[1] < 14 || p < 16) {
                                              ^^^^^^
The GLSL ES 1.0 spec states that the minimum required value of p for mediump
is 10, not 16. 16 is the minimum required for highp.

- -Chad
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJP+v6sAAoJEAIvNt057x8iKI4P/3zWFTJSDTo+yHsUj3QjbgwY
ngO9ZnvkcYYVlISwZ4R//g7s83SuRUhQFEGT2e5UGwzr160C3zshL+RSEXG11nSX
SzlXRL5tXxcg5H9b52Z1o7i6PvvgQXnq68vWvSk1iKqvglpWkp4dLIdaDNDz3yOa
b0Av/TakhYVY+Kj7TqZZ5S/bxmbkN799+ChGJ0D3hCEHQltRe4c5phChTIh65Ltz
a2voxcc7OuqDYeKnj4fRIFHssjGXla7306TXckfq8PC9y20x9hqWvGra89kWYxw1
2pyeqsXl3B7gzq9UETP+M6V/2s4pBcHR5lEJFlEQcVpmNbFnS+AaGRQZG86qDG1r
slXiAyPdFIhAGwW6qsPNnhkqimVM0gdeYY4HB68YZ4xcikK3QEOXhFfiLDDG4O9m
9XvhDx2EuW72j/Yf3TOuiSVai8IpXVuY8UVV9aH6C5P1CFX1xNa1D3apfFF3Jo/t
ZtKrgll1k0MNzySCR4zE2lSDU/UdAaDQzEyQNwwQ3MPHcy34nUDaBCdGkNRKu5qp
i9AZhT03HDyqrHiQ2bef6rrQYIQmJq+EKKChNmYNT00vIA8bday8CPE5lTtgubBo
smJUQ0x2uXA8WH1yXnwHWs1ZfWcrfaZvlWErXJ68LGYF4zpKZVTJXNI5CnwgxchI
trJt0VUDUiAmaD4BuXS0
=FX/J
-----END PGP SIGNATURE-----