[Piglit] [PATCH v2 06/13] piglit-dispatch: Additions to OpenGL API spec files.

[Paul Berry]

On 13 March 2012 11:33, Chad Versace <chad.versace at linux.intel.com> wrote:

> On 03/12/2012 02:41 PM, Paul Berry wrote:
> > This patch adds descriptions of the extensions
> > OES_compressed_paletted_texture, ATI_texture_compression_3dc, and
> > NVX_gpu_memory_info to the OpenGL API spec files.  The extension
> > OES_compressed_paletted_texture was previously commented out (since it
> > is part of GLES), and the others weren't present at all.
> > ---
> >  glapi/enumext.spec |   31 +++++++++++++++++++++----------
> >  1 files changed, 21 insertions(+), 10 deletions(-)
>
> The patch is correct---the macros match those found in glew.h---but
> the commit message doesn't say why you needed to add these extensions.
> Are you adding the tokens only because they are present in glew? Because
> some Piglit tests use them? With a comment to that effect, this is
>
> Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
>

I added the tokens because they were needed to compile Piglit.  I've
modified the commit message to read as follows:

This patch adds enums for the following extensions to the OpenGL API
spec files:

- OES_compressed_paletted_texture: This extension defines 10 enums,
  which are required to compile the test
  "spec/OES_compressed_paletted_texture/invalid formats".  These enums
  were already present in the OpenGL API spec files, but they were
  commented out (since they are part of GLES).

- ATI_texture_compression_3dc: These enums are required to compile the
  test "spec/ARB_texture_compression/unknown formats".

- NVX_gpu_memory_info: These enums are required to compile the file
  "tests/util/piglit-util-enum.c".




>
> >
> > diff --git a/glapi/enumext.spec b/glapi/enumext.spec
> > index ead6983..ed70c78 100644
> > --- a/glapi/enumext.spec
> > +++ b/glapi/enumext.spec
> > @@ -6063,16 +6063,16 @@ ATI_vertex_attrib_array_object enum:
> >
> >  # Extension #294 - OpenGL ES only, not in glext.h
> >  # OES_compressed_paletted_texture enum:
> > -#    PALETTE4_RGB8_OES                               = 0x8B90
> > -#    PALETTE4_RGBA8_OES                              = 0x8B91
> > -#    PALETTE4_R5_G6_B5_OES                           = 0x8B92
> > -#    PALETTE4_RGBA4_OES                              = 0x8B93
> > -#    PALETTE4_RGB5_A1_OES                            = 0x8B94
> > -#    PALETTE8_RGB8_OES                               = 0x8B95
> > -#    PALETTE8_RGBA8_OES                              = 0x8B96
> > -#    PALETTE8_R5_G6_B5_OES                           = 0x8B97
> > -#    PALETTE8_RGBA4_OES                              = 0x8B98
> > -#    PALETTE8_RGB5_A1_OES                            = 0x8B99
> > +     PALETTE4_RGB8_OES                               = 0x8B90
> > +     PALETTE4_RGBA8_OES                              = 0x8B91
> > +     PALETTE4_R5_G6_B5_OES                           = 0x8B92
> > +     PALETTE4_RGBA4_OES                              = 0x8B93
> > +     PALETTE4_RGB5_A1_OES                            = 0x8B94
> > +     PALETTE8_RGB8_OES                               = 0x8B95
> > +     PALETTE8_RGBA8_OES                              = 0x8B96
> > +     PALETTE8_R5_G6_B5_OES                           = 0x8B97
> > +     PALETTE8_RGBA4_OES                              = 0x8B98
> > +     PALETTE8_RGB5_A1_OES                            = 0x8B99
> >
> >
>  ###############################################################################
> >
> > @@ -7323,3 +7323,14 @@ AMD_stencil_operation_extended enum:
> >       STENCIL_OP_VALUE_AMD                            = 0x874C
> >       STENCIL_BACK_OP_VALUE_AMD                       = 0x874D
> >
> > +# Extension #???
> > +ATI_texture_compression_3dc enum:
> > +        COMPRESSED_LUMINANCE_ALPHA_3DC_ATI           = 0x8837
> > +
> > +# Extension #???
> > +NVX_gpu_memory_info enum:
> > +        GPU_MEMORY_INFO_DEDICATED_VIDMEM_NVX            = 0x9047
> > +        GPU_MEMORY_INFO_TOTAL_AVAILABLE_MEMORY_NVX      = 0x9048
> > +        GPU_MEMORY_INFO_CURRENT_AVAILABLE_VIDMEM_NVX    = 0x9049
> > +        GPU_MEMORY_INFO_EVICTION_COUNT_NVX              = 0x904A
> > +        GPU_MEMORY_INFO_EVICTED_MEMORY_NVX              = 0x904B
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120313/9af7dae5/attachment.html>