[Piglit] [PATCH v2 06/13] piglit-dispatch: Additions to OpenGL API spec files.

Jose Fonseca jfonseca at vmware.com
Tue Mar 13 23:54:13 PDT 2012

> On 13 March 2012 11:33, Chad Versace < chad.versace at linux.intel.com >
> wrote:
> > The patch is correct---the macros match those found in glew.h---but
> > the commit message doesn't say why you needed to add these
> > extensions.
> > Are you adding the tokens only because they are present in glew?
> > Because
> > some Piglit tests use them? With a comment to that effect, this is

> > Reviewed-by: Chad Versace < chad.versace at linux.intel.com >

> I added the tokens because they were needed to compile Piglit. I've
> modified the commit message to read as follows:

> This patch adds enums for the following extensions to the OpenGL API
> spec files:


> - NVX_gpu_memory_info: These enums are required to compile the file
> "tests/util/piglit-util-enum.c".

There was a request for apitrace to support these enums, which is why they landed in here. But NVX_gpu_memory_info is an unofficial extension, and I don't think it will be useful for piglit.  So it's fine to remove all references to these NVX_gpu_memory_info tokens instead if it makes things simpler.


More information about the Piglit mailing list