[Piglit] [PATCH v3 00/19] Replace glew with a custom Piglit dispatch mechanism

Jose Fonseca jfonseca at vmware.com
Thu Mar 22 02:12:02 PDT 2012

----- Original Message -----
> This is version 3 (hopefully the final version) of my attempt to
> replace Piglit's use of GLEW with a home-spun dispatch layer that
> will
> work with GLES, Wayland, and forward compatible contexts.  (Version 2
> can be found in the email "[PATCH v2 00/13] Replace glew with a
> custom
> Piglit dispatch mechanism").
> I now believe everything works as well as it did before on Linux,
> Windows, and Mac (with the exception of one minor regression on Mac
> that I think is worth deferring--see below).  I have not yet
> implemented support for GLES or Wayland; I'm planning to wait for a
> later patch series to do those.
> As with the previous patch series, a few of the patches are too large
> for the mailing list, so I've omitted them.  You can see the whole
> series by pulling from branch "dispatch3" of
> git://github.com/stereotype441/piglit.git.
> Note that some of the commits have already been code reviewed, so I'm
> including the "Reviewed-by" comments in the patch emails.
> Changes since version 2:
> - Code now builds and runs correctly on Windows.  This required
>   carefully choosing the right calling conventions for all the
>   functions.  It also required distinguishing between core GL
>   functions that were introduced in GL 1.0 or GL 1.1 and core
>   functions that were introduced later.  (Only the latter set can be
>   obtained using wglGetProcAddress(); the former set need to be
>   looked
>   up directly in OPENGL32.dll).
> - By popular demand, the generated code is no longer checked into
> git.
>   This patch series now includes the necessary modifications to cmake
>   to ensure that all tests are rebuilt if the generated code ever
>   changes (thanks to Chad Versace for helping me to get this
>   working).

Thanks for both changes. The patch series looks great to me.


More information about the Piglit mailing list