[Piglit] [PATCH] GL_ARB_framebuffer_object/negative-readpixels-no-rb: Test for Mesa segfault.

[Brian Paul]

On 11/13/2012 03:11 PM, Eric Anholt wrote:
> ---
>   tests/all.tests                                    |    1 +
>   .../spec/arb_framebuffer_object/CMakeLists.gl.txt  |    1 +
>   .../negative-readpixels-no-rb.c                    |   87 ++++++++++++++++++++
>   3 files changed, 89 insertions(+)
>   create mode 100644 tests/spec/arb_framebuffer_object/negative-readpixels-no-rb.c
>
> diff --git a/tests/all.tests b/tests/all.tests
> index 35211ce..33c3482 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -979,6 +979,7 @@ arb_framebuffer_object['FBO blit to missing attachment'] = PlainExecTest(['fbo-m
>   arb_framebuffer_object['FBO blit from missing attachment'] = PlainExecTest(['fbo-missing-attachment-blit', '-auto', 'from'])
>   arb_framebuffer_object['fbo-scissor-blit fbo'] = PlainExecTest(['fbo-scissor-blit', 'fbo', '-auto'])
>   arb_framebuffer_object['fbo-scissor-blit window'] = PlainExecTest(['fbo-scissor-blit', 'window', '-auto'])
> +arb_framebuffer_object['negative-readpixels-no-rb'] = concurrent_test('arb_framebuffer_object-negative-readpixels-no-rb')
>
>   # Group ARB_framebuffer_sRGB
>   arb_framebuffer_srgb = Group()
> diff --git a/tests/spec/arb_framebuffer_object/CMakeLists.gl.txt b/tests/spec/arb_framebuffer_object/CMakeLists.gl.txt
> index 33b09c1..9faeb8e 100644
> --- a/tests/spec/arb_framebuffer_object/CMakeLists.gl.txt
> +++ b/tests/spec/arb_framebuffer_object/CMakeLists.gl.txt
> @@ -12,6 +12,7 @@ link_libraries (
>
>   piglit_add_executable(framebuffer-blit-levels framebuffer-blit-levels.c)
>   piglit_add_executable(get-renderbuffer-internalformat get-renderbuffer-internalformat.c)
> +piglit_add_executable(arb_framebuffer_object-negative-readpixels-no-rb negative-readpixels-no-rb.c)
>   piglit_add_executable(same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT.c)
>   piglit_add_executable(same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT.c)
>
> diff --git a/tests/spec/arb_framebuffer_object/negative-readpixels-no-rb.c b/tests/spec/arb_framebuffer_object/negative-readpixels-no-rb.c
> new file mode 100644
> index 0000000..ab36c3c
> --- /dev/null
> +++ b/tests/spec/arb_framebuffer_object/negative-readpixels-no-rb.c
> @@ -0,0 +1,87 @@
> +/*
> + * Copyright © 2012 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +/** @file readpixels-no-color-buffer.c
> + *
> + * Test that glReadPixels(GL_RGBA) when there is no corresponding
> + * attachment bound correctly returns GL_INVALID_OPERATION.
> + */
> +
> +#include<stdio.h>
> +#include "piglit-util-gl-common.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +	config.supports_gl_compat_version = 10;
> +	config.supports_gl_core_version = 31;
> +
> +	config.window_width = 1;
> +	config.window_height = 1;

Windows will "warn" on (and skip) any test with window width < 116 so 
until we have some other solution in place I suggest removing the 
width/height entirely.


> +	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +enum piglit_result
> +piglit_display()
> +{
> +	/* UNREACHED */
> +	return PIGLIT_FAIL;
> +}
> +
> +static bool
> +test_bad_readpixels(GLenum format, GLenum type)
> +{
> +	uint32_t junk[4];
> +	glReadPixels(0, 0, 1, 1, format, type, junk);
> +	return piglit_check_gl_error(GL_INVALID_OPERATION);
> +}
> +
> +void piglit_init(int argc, char **argv)
> +{
> +	GLuint fb, rb;
> +	bool pass = true;
> +
> +	piglit_require_extension("GL_ARB_framebuffer_object");
> +
> +	glGenFramebuffers(1,&fb);
> +	glBindFramebuffer(GL_FRAMEBUFFER, fb);
> +	glGenRenderbuffers(1,&rb);
> +	glBindRenderbuffer(GL_RENDERBUFFER, rb);
> +
> +	glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT, 1, 1);
> +	glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT,
> +				  GL_RENDERBUFFER, rb);
> +	pass = test_bad_readpixels(GL_RGBA, GL_FLOAT)&&  pass;
> +	glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT,
> +				  GL_RENDERBUFFER, 0);
> +
> +	glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA, 1, 1);
> +	glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
> +				  GL_RENDERBUFFER, rb);
> +	pass = test_bad_readpixels(GL_DEPTH_COMPONENT, GL_FLOAT)&&  pass;
> +	pass = test_bad_readpixels(GL_STENCIL_INDEX, GL_FLOAT)&&  pass;
> +	glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
> +				  GL_RENDERBUFFER, 0);
> +
> +	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +}


Reviewed-by: Brian Paul <brianp at vmware.com>